feat: add debug builds for CI #1641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably fixes other issues, but makes it so windows debug builds work again also adds windows debug building to catch this stuff
EmosewaMC
commented
Oct 27, 2024
CMakePresets.json
Outdated
| "exclude": { | ||
| "name": "((example)|(minigzip))+" | ||
| } | ||
| "configurePresets": [ |
There was a problem hiding this comment.
We had to do the whitespace changes at somepoint sorry 🙈
EmosewaMC
force-pushed
the
fix-windows-debug
branch
from
9df7b63 to
0509aaf
Compare
aronwk-aaron
approved these changes
Oct 30, 2024
|
This isn't quite configured correctly, I don't think. MSVC builds are handled a bit differently and (generally) shouldn't require separate configurations for debug and release because the MSVC build system is smart enough to be able to read the build preset instead. |
|
Since we merged #1439, one thing I think that might be worth further research on your end is whether we need to keep some of these MSVC presets. On my end, both 'Windows Only Configure Settings' and 'Default' don't work properly. I'd remove them myself, but I'm not sure if they serve some use for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alongside that, fixes the issues caused by adding said pipelines
(copying over the shared libraries to directories where they are expected to exist on windows and mac)